Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcut to maximize the current/focus/active view #1409

Closed
slicerbot opened this issue Mar 12, 2020 · 4 comments
Closed

Add shortcut to maximize the current/focus/active view #1409

slicerbot opened this issue Mar 12, 2020 · 4 comments
Assignees
@lassoan
Labels
make-simple-things-simple "Make simple things simple and complex things possible" - to improve Slicer usability Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Milestone
Slicer 4.13

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
@lassoan
Copy link
Contributor

lassoan commented Mar 17, 2020

Calling the same shortcut again would restore the original layout.

This feature is commonly available in other software and users asked for it a couple of times.

@lassoan lassoan added Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality labels Mar 17, 2020
@lassoan lassoan added this to the Backlog milestone Mar 17, 2020
@lassoan lassoan added the make-simple-things-simple "Make simple things simple and complex things possible" - to improve Slicer usability label Feb 4, 2021
@lassoan
Copy link
Contributor

lassoan commented Feb 4, 2021

See also discussion here: https://discourse.slicer.org/t/double-click-to-maximize-view/15824/3

@lassoan
Copy link
Contributor

lassoan commented Jun 9, 2021

See discussion of implementation here: https://discourse.slicer.org/t/lnk2019-error-while-importing-functions-from-different-class/18026/2

@lassoan
Copy link
Contributor

lassoan commented Jul 21, 2021

More discussion of how this can be implemented: https://discourse.slicer.org/t/add-button-to-maximize-view/18092

lassoan added a commit to jahnavigouru/Slicer that referenced this issue Aug 30, 2021
@lassoan @jahnavigouru
ENH: Allow temporarily maximize a view in the layout
d337d30 
Clicking "maximize" button in the header of the view controller makes the corresponding view maximized in the view layout. Clicking the button again restores the original view layout.

Shortcuts added to access this feature without leaving the view:
- double-click in an empty area in the view maximizes/restores a view
- "Maximize" / "Restore view layout" actions view context menu (right-clicking in an empty area)

Implementation: A new MaximizedViewNode node reference is added to vtkMRMLLayoutNode. If MaximizedViewNode is set to a valid view node then that view is displayed instead of the views defined by vtkMRMLLayoutNode::GetCurrentLayoutDescription(). The current layout ID or description in the layout node is not changed, the override happens at lower level, in qMRMLLayoutManager. The commit moves storage and observation of view nodes from various view controller widgets to the nodes into the parent qMRMLViewControllerBar to reduce code duplication.

fixes Slicer#1409

Co-authored-by: jahnavi0801 <jahnavi0801@gmail.com>
@lassoan lassoan closed this as completed in fdb8362 Sep 1, 2021
@lassoan lassoan modified the milestones: Backlog, Slicer 4.13.0 Sep 1, 2021
@lassoan lassoan self-assigned this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
make-simple-things-simple "Make simple things simple and complex things possible" - to improve Slicer usability Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Milestone
Slicer 4.13
Development

No branches or pull requests
2 participants
@lassoan @slicerbot