View Issue Details

IDProjectCategoryView StatusLast Update
0001619Slicer4Core: Base Codepublic2015-11-04 04:39
ReporterjcfrAssigned Tofedorov 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionwon't fix 
Product Version 
Target VersionFixed in Version 
Summary0001619: CLI - BSplineToDeformationField module has no test
Description

Would it make sens to add some test ?

Test data should be hosted on midas. See http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/UploadTestData

TagsNo tags attached.

Relationships

related to 0002398 acknowledgedjcfr Remove the EMSegment module from the Slicer install package and distribute it as an extension 

Activities

jcfr

jcfr

2013-08-28 13:12

administrator   ~0009674

See r22351 - http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22351

// ------------------------------
COMP: Disable configure time message mentioning some CLIs have NO tests

These messages (introduced by r20160 more than a year ago) didn't have
the intended effect. Despite the fact developer were systematically
looking at these warning message, they became "noise" and have been ignored.

This commit disables the warning message and reference a mantis issue
tracking the fact there is no test.

See 0001619, 0003333, 0003334, 0003335, 0003336, 0003337, 0003338, 0003339, 0003340, 0003341

fedorov

fedorov

2013-08-28 13:35

developer   ~0009684

As a side note, I gave this particular module to Kilian Pohl for his EMSegment project, to help him improve the performance issues in EMSegment pipeline, see commit history here: http://viewvc.slicer.org/viewvc.cgi/Slicer4/trunk/Modules/CLI/BSplineToDeformationField/BSplineToDeformationField.cxx?view=log

I didn't commit this module and didn't plan to support it. Just wanted to have this history trivia here for the record. I will add a test when I have time.

jcfr

jcfr

2013-08-28 13:50

administrator   ~0009685

At some point we will very probably create an EMSegment extension also bundling Tcl/tk, I guess the module BSplineToDeformationField could also bundled in the same extension.

fedorov

fedorov

2015-11-04 04:27

developer   ~0013549

considering EMSegment is the only user of this extension, I defer to EMSegment developers to prioritize this task

jcfr

jcfr

2015-11-04 04:39

administrator   ~0013551

Thanks Andriy.

For reference, the module has also been deprecated and belong to the Legacy category. See http://wiki.slicer.org/slicerWiki/index.php/Documentation/Labs/DeprecatedModules

Issue History

Date Modified Username Field Change
2011-12-07 21:25 jcfr New Issue
2011-12-07 21:25 jcfr Status new => assigned
2011-12-07 21:25 jcfr Assigned To => finetjul
2011-12-07 21:41 finetjul Assigned To finetjul => fedorov
2011-12-08 06:54 fedorov Status assigned => acknowledged
2012-08-22 05:56 jcfr Target Version => Slicer 4.3.0
2013-08-28 12:16 pieper Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-08-28 12:33 jcfr Description Updated
2013-08-28 13:12 jcfr Note Added: 0009674
2013-08-28 13:35 fedorov Note Added: 0009684
2013-08-28 13:50 jcfr Note Added: 0009685
2014-05-13 19:51 jcfr Target Version Slicer 4.4.0 =>
2014-05-13 19:53 jcfr Relationship added related to 0002398
2015-11-04 04:27 fedorov Note Added: 0013549
2015-11-04 04:27 fedorov Status acknowledged => closed
2015-11-04 04:27 fedorov Resolution open => won't fix
2015-11-04 04:39 jcfr Note Added: 0013551