View Issue Details

IDProjectCategoryView StatusLast Update
0002398Slicer4Core: Packagingpublic2015-09-22 18:44
ReporterlassoanAssigned Tojcfr 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0002398: Remove the EMSegment module from the Slicer install package and distribute it as an extension
Description

The size of the EMSegment module files is more than 100MB and probably very few people use it.

The Slicer install package would be significantly smaller if the EMSegment module was distributed as an extension instead.

TagsNo tags attached.

Relationships

related to 0003401 closedjcfr Remove Slicer legacy module from the trunk 
related to 0001619 closedfedorov CLI - BSplineToDeformationField module has no test 

Activities

inorton

inorton

2013-12-17 12:00

developer   ~0010442

EMSegment appears to be breaking the build on linux.

jcfr

jcfr

2013-12-17 12:19

administrator   ~0010443

What is the error ?

inorton

inorton

2013-12-17 12:32

developer   ~0010444

Last edited: 2013-12-17 12:33

Linking CXX executable ../../../../bin/qSlicerAppCxxTests
/usr/bin/ld: cannot find -lvtkSlicerEMSegmentModuleLogic

I tried commenting out EMSegment from SuperBuild.cmake but that didn't help.

jcfr

jcfr

2013-12-17 14:01

administrator   ~0010445

Strange. Did you do a clean build ?
the dashboard show up clean .. see http://slicer.cdash.org/buildSummary.php?buildid=178456

Simply commenting EMSegment won't do it, the associated option need to be disabled. Otherwise, the library will still be expected. See [1]

If you do a build from the top level including EMSegment, do you confirm that the following text appear when the Slicer inner project is configured:

[...]
-- Configuring SEM CLI module: EMSegmentCommandLine
-- Configuring SEM CLI module: EMSegmentTransformToNewFormat
-- Configuring Loadable module: EMSegment [qSlicerEMSegmentModuleExport.h]
-- Configuring Loadable module: EMSegmentQuick [qSlicerEMSegmentQuickModuleExport.h]
[...]

[1] https://github.com/Slicer/Slicer/blob/master/Applications/SlicerApp/Testing/Cpp/CMakeLists.txt#L33

inorton

inorton

2013-12-18 07:12

developer   ~0010448

It seems that a clean superbuild is in order because the BUILD_EMSegment option does not show up in cmake, whereas in a new build directory it does.

jcfr

jcfr

2013-12-18 11:18

administrator   ~0010449

Sounds good. Keep me posted of your findings.

jcfr

jcfr

2015-09-22 10:35

administrator   ~0013300

Maintaining this extension implies some work (mainly related to keeping tcl/tk support in good shape). Building EMSegment as an extension wouldn't remove the burden associated with the tcl/tk maintenance.

lassoan

lassoan

2015-09-22 18:34

developer   ~0013304

Do we really need TCL? It should not be difficult to port TCL code to Python.

jcfr

jcfr

2015-09-22 18:44

administrator   ~0013305

Do we really need TCL?

My understanding is that there is EMSegment "profile" or "task" definition implemented in Tcl.

It would be worth checking with Kilian if this still applies.

Issue History

Date Modified Username Field Change
2012-08-14 11:38 lassoan New Issue
2012-08-14 11:38 lassoan Status new => assigned
2012-08-14 11:38 lassoan Assigned To => jcfr
2012-08-21 11:57 jcfr Target Version => Slicer 4.3.0
2013-08-30 20:29 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-12-17 12:00 inorton Note Added: 0010442
2013-12-17 12:00 inorton Assigned To jcfr => pohl
2013-12-17 12:19 jcfr Note Added: 0010443
2013-12-17 12:32 inorton Note Added: 0010444
2013-12-17 12:33 inorton Note Edited: 0010444
2013-12-17 14:01 jcfr Note Added: 0010445
2013-12-18 07:12 inorton Note Added: 0010448
2013-12-18 11:18 jcfr Note Added: 0010449
2014-05-13 16:15 jcfr Assigned To pohl => jcfr
2014-05-13 19:53 jcfr Relationship added related to 0003401
2014-05-13 19:53 jcfr Relationship added related to 0001619
2014-07-29 10:09 jcfr Target Version Slicer 4.4.0 => Slicer 4.5.0-1
2015-09-22 10:33 jcfr Status assigned => acknowledged
2015-09-22 10:33 jcfr Target Version Slicer 4.5.0-1 =>
2015-09-22 10:35 jcfr Note Added: 0013300
2015-09-22 18:34 lassoan Note Added: 0013304
2015-09-22 18:44 jcfr Note Added: 0013305