View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002486||Slicer4||Core: MRML||public||2012-09-07 06:45||2018-05-29 23:46|
|Target Version||backlog||Fixed in Version|
|Summary||0002486: Remove duplicate saving of node contents to scene and separate file|
I'm voting for A, to move the storable plain text data out of the .mrml files and keep them only in their separate files on disk. I did a quick experiment with the color tables, but it didn't work cleanly right away so I pushed it back to after the 4.2 release (if nothing else it shouldn't be writing out the non named colors). The fiducials will be only in files after the Annotations module re-write is finalised.
On 09/07/2012 10:20 AM, Andras Lasso wrote:
|Tags||No tags attached.|
The current convention on loading mrml scenes is that data files
I noticed that in particular vector field transform is stored in the
svn 20977 reduces the size of the mrml scene a bit by not writing out non named colors. Still have to test if this leads to fixing the problems I saw with not writing out colors in mrml at all and just relying on storage node files.
vtkMRMLGridTransformNode stores the displacement values in the MRML. I can remove them, but it may cause compatibility issues if somebody relies on the data being present in MRML
Just write an email to the developer and user mailing list that you plan to remove the storage from the Scene file. If nobody objects for one week then you can go on and remove.
Removed grid transform displacement field output to MRML file.
Yes, the numcolors tag needs to come before the colors tag, due to the
There's a Mantis issue open that will track work to remove the color
A safer way to incorporate your custom color file is to load the ctbl
The warnings are from the order of reading the volume nodes, display
Revisiting this, here's Alex's check in to remove grid transform displacement fields:
Closing the scene, adding a new color file to the scene, and making a copy so there's a new one, then saving... didn't save the mrml file. Checking it to save it, the non empty color entries are saved to both mrml and the ctbl file.
Exit and restart, added 5 fiducials, 2 rulers, 1 ROI, then saved:
So: nodes that got moved out of mrml: fiducials, grid transform.
Did some testing and leaving in the number of colors in the color table in mrml but not writing out the colors seems to be working (aka no crashes like I had last time I tried to fix this). Checked that in as svn 22344.
Looking again at the Annotation nodes, I would advise against modifying the Ruler and ROI to not write their control points into MRML.
@Alex: Could you update both Nighly / 4.3 module documentation ?
Not clear when there will be time to work on this.
Retargeting stale issues to backlog.
Slicer: 2145-support-for-installing-extension-from-file 80740a1b
|BUG: remove color table entries from mrml file
Rely on the file written to disk by the storage node,
reduces the size of the mrml file.
Keep the number of colors in the mrml file so that the
table is properly initialised.
git-svn-id: http://svn.slicer.org/Slicer4/trunk@22344 3bd1e089-480b-0410-8dfb-8563597acbee
|mod - Libs/MRML/Core/vtkMRMLColorTableNode.cxx||Diff File|
|2012-09-07 06:45||lassoan||New Issue|
|2012-09-07 06:45||lassoan||Status||new => assigned|
|2012-09-07 06:45||lassoan||Assigned To||=> alexy|
|2012-09-07 07:03||alexy||Note Added: 0006005|
|2012-09-12 11:06||nicole||Note Added: 0006045|
|2012-09-18 09:02||alexy||Note Added: 0006124|
|2012-09-18 09:03||alexy||Note Edited: 0006124|
|2012-09-18 10:06||lassoan||Note Added: 0006126|
|2012-09-21 05:56||alexy||Note Added: 0006157|
|2012-09-21 05:56||alexy||Assigned To||alexy => millerjv|
|2012-11-12 06:51||jcfr||Target Version||=> Slicer 4.3.0|
|2012-11-12 06:51||jcfr||Note Added: 0007162|
|2013-08-27 12:40||jcfr||Assigned To||millerjv => nicole|
|2013-08-27 14:11||nicole||Note Added: 0009652|
|2013-08-27 15:25||nicole||Note Added: 0009655|
|2013-08-27 15:25||nicole||Assigned To||nicole => alexy|
|2013-08-30 12:07||jcfr||Target Version||Slicer 4.3.0 => Slicer 4.3.1|
|2013-09-10 12:41||jcfr||Severity||major => minor|
|2013-09-10 12:41||jcfr||Target Version||Slicer 4.3.1 => Slicer 4.4.0|
|2013-09-10 12:43||jcfr||Note Added: 0009924|
|2014-03-07 06:39||pieper||Status||assigned => acknowledged|
|2014-03-07 06:40||pieper||Note Added: 0011334|
|2014-03-07 06:40||pieper||Target Version||Slicer 4.4.0 =>|
|2017-06-07 23:27||Changeset attached||=> Slicer 2145-support-for-installing-extension-from-file 80740a1b|
|2018-05-29 23:46||lassoan||Target Version||=> backlog|
|2018-05-29 23:46||lassoan||Note Added: 0015788|