Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend vtkMRMLNode::Copy behavior #2608

Closed
slicerbot opened this issue Mar 12, 2020 · 1 comment
Closed

Extend vtkMRMLNode::Copy behavior #2608

slicerbot opened this issue Mar 12, 2020 · 1 comment
Assignees
@lassoan
Milestone
Slicer 4.13

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 12, 2020
@lassoan lassoan self-assigned this Mar 26, 2020
jcfr pushed a commit to jcfr/Slicer that referenced this issue Apr 16, 2020
@lassoan @jcfr
ENH: Refactor MRML node API to support shallow and deep copy
f1ae1e8 
This commit updates the MRML node API for copying node content to allow
shallow/deep-copy of node content (without node references, name, ID, etc.)

It adds CopyContent method to copy node content only (without node name,
references, etc.) with the option of doing fast shallow-copy or full deep-copy.

It adds vtkMRMLCopyContentMacro to specify if CopyContent method is
implemented for the current class.

Since it is easy to suppress modified events externally, it also removes
CopyWithSingleModifiedEvent, CopyWithoutModifiedEvent, and
CopyWithSceneWithSingleModifiedEvent to simplify node copy API.

See Slicer#2608
@jcfr jcfr mentioned this issue Apr 16, 2020
Merged
jcfr pushed a commit to jcfr/Slicer that referenced this issue Apr 16, 2020
@lassoan @jcfr
ENH: Refactor MRML node API to support shallow and deep copy
af30905 
This commit updates the MRML node API for copying node content to allow
shallow/deep-copy of node content (without node references, name, ID, etc.)

It adds CopyContent method to copy node content only (without node name,
references, etc.) with the option of doing fast shallow-copy or full deep-copy.

It adds vtkMRMLCopyContentMacro to specify if CopyContent method is
implemented for the current class.

Since it is easy to suppress modified events externally, it also removes
CopyWithSingleModifiedEvent, CopyWithoutModifiedEvent, and
CopyWithSceneWithSingleModifiedEvent to simplify node copy API.

See Slicer#2608
jcfr pushed a commit that referenced this issue Apr 17, 2020
@lassoan @jcfr
ENH: Refactor MRML node API to support shallow and deep copy
f88c110 
This commit updates the MRML node API for copying node content to allow
shallow/deep-copy of node content (without node references, name, ID, etc.)

It adds CopyContent method to copy node content only (without node name,
references, etc.) with the option of doing fast shallow-copy or full deep-copy.

It adds vtkMRMLCopyContentMacro to specify if CopyContent method is
implemented for the current class.

Since it is easy to suppress modified events externally, it also removes
CopyWithSingleModifiedEvent, CopyWithoutModifiedEvent, and
CopyWithSceneWithSingleModifiedEvent to simplify node copy API.

See #2608
@jcfr
Copy link
Member

jcfr commented Apr 17, 2020

Closing. Fixed in #4830

@jcfr jcfr closed this as completed Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
None yet
Milestone
Slicer 4.13
Development

No branches or pull requests
3 participants
@jcfr @lassoan @slicerbot