New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VR displayable manager should not show display node that are not referenced by displayable node #2628
Comments
@cpinter is this issue still relevant? |
It is true that vol.ren. display nodes explicitly reference the volume node unlike other display nodes including the volume displayable node, which do an exhaustive search in the scene (but it has a one-item cache, see LastFoundDisplayableNode). And this reference is set in the logic by the UpdateDisplayNodeFromVolumeNode function (and I think this is part of the reason volume rendering doesn't work without having to call these update functions). It seems that this explicit reference has performance reasons, because it is faster to get the volume node from the display node in the displayable manager in functions like UpdateDisplayNodePipeline. It may make sense to try and remove this extra complexity because it seems unlikely that performance would noticeably decrease.
I'm not sure if this could be a problem or whether it is handled by the current code. However, doing the simplification would solve it for sure. |
Thanks for the analysis. I'll take care of this then. |
…splay node vtkMRMLVolumeRenderingDisplayNode::SetAndObserveVolumeNodeID method was removed, as display node base class already maintains a pointer to the displayed (volume) node. Updated migration guide (https://www.slicer.org/wiki/Documentation/Nightly/Developers/Tutorials/MigrationGuide/Slicer#Volume_rendering). Fixes Slicer#2628.
…splay node vtkMRMLVolumeRenderingDisplayNode::SetAndObserveVolumeNodeID method was removed, as display node base class already maintains a pointer to the displayed (volume) node. Updated migration guide (https://www.slicer.org/wiki/Documentation/Nightly/Developers/Tutorials/MigrationGuide/Slicer#Volume_rendering). Fixes #2628.
This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
The text was updated successfully, but these errors were encountered: