Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtkMRMLNode::SetScene() should be protected and set by scene #2713

Open
slicerbot opened this issue Mar 12, 2020 · 2 comments
Open

vtkMRMLNode::SetScene() should be protected and set by scene #2713

slicerbot opened this issue Mar 12, 2020 · 2 comments
Assignees
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@lassoan lassoan added Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality labels Mar 20, 2020
@lassoan lassoan added this to the Slicer 4.11.0 milestone Mar 20, 2020
@lassoan
Copy link
Contributor

lassoan commented Mar 20, 2020

Slicer5 is a good opportunity to make such API changes.

@lassoan lassoan self-assigned this Mar 26, 2020
@lassoan
Copy link
Contributor

lassoan commented Jul 28, 2021

Looked at it and it is not so trivial, due to storage, color, and scene view nodes sometimes rely on setting a scene but not adding the node to the scene.

@lassoan lassoan modified the milestones: Slicer 4.13.0, Backlog Jul 28, 2021
lassoan added a commit to lassoan/Slicer that referenced this issue Jul 28, 2021
Workin progress, there are still lots of failed tests.

Not trivial due to storage nodes (that may use the scene for looking up cached files), scene view nodes, color nodes.
Probably should be done in several steps.

see Slicer#2713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Development

No branches or pull requests

2 participants