Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks when returning vtkCollection objects to Python as return value #2718

Open
slicerbot opened this issue Mar 12, 2020 · 1 comment
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@lassoan
Copy link
Contributor

lassoan commented Mar 20, 2020

VTK's Python wrapping now supports factory methods (the Python wrapper unregisters the new object so that only the Python variable keeps a reference to it), but adding the flag to the existing method would cause hard-to-catch errors. Probably the best would be to completely change the method's signature for a few years (make it take a collection as input as suggested in the issue) and after that the method could return with the new improved behavior.

@lassoan lassoan added Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality labels Mar 20, 2020
@lassoan lassoan modified the milestones: Slicer 4.11.0, Backlog Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Development

No branches or pull requests

2 participants