View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002732||Slicer4||Core: MRML||public||2012-11-05 10:35||2014-03-06 05:13|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||Slicer 4.2.1||Fixed in Version||Slicer 4.2.1|
|Summary||0002732: Move LightBox proxy to abstract displayable manager for easier re-use|
" move the lightbox proxy up to the abstract displayable manager class level so that it is available to all displayable manager subclasses. This would mean adding it to the initialize methods for the displayable manager groups. ThreeD displayable managers could just return the single renderer, while slice views could use the proxy to get the correct renderer for the given coordinate (Z coordinate of XYZ space)."
|Tags||No tags attached.|
As an added feature request consider, it would be great if you could switch the active displayable managers on the fly (that is, register/unregister displayable managers and refresh the currently instanced views to reflect the updated state). Last time I looked it didn't appear to be possible to modify displayable managers after the fact.
Jim: any updates?
No update yet.
Pushed a patch to https://github.com/millerjv/Slicer4/commit/55f9c1c637f4ef4ba5c0da8b442aac57626d10c7 [^]
Branch is "2732-move-lightbox-to-abstract-displayable-manager"
Nicole, does this address what you need for the annotations?
Or does the lightbox proxy need to be push through the 3D Widgets (ctkVTKRenderView) as well?
Jim: I don't need it in the 3D view, that will have a different way of dealing with renderers when there are multiple 3D views.
So a potential problem is if a displayable manager is registered with the displayable manager group after the light box renderer manager proxy is set, it won't have had that passed to it. I think some extra checking might be needed when registering dislayable managers with the group/factory...
I wasn't sure when the annotation displayable managers were added to the viewers.
I followed Jc's suggestion and modified the DisplayableManagerGroup::AddDisplayableManager() to pass along the cached LightBoxRendererManagerProxy.
In theory, when you add your displayable managers to the viewers, they will be configured with the proxy now. So need to try to manage the proxy yourself.
There is a new commit on the branch.
Fixed in r21431
Closing resolved issues that have not been updated in more than 3 months
|2012-11-05 10:35||jcfr||New Issue|
|2012-11-05 10:35||jcfr||Status||new => assigned|
|2012-11-05 10:35||jcfr||Assigned To||=> alexy|
|2012-11-05 10:35||jcfr||Reporter||jcfr => pieper|
|2012-11-05 10:35||jcfr||Assigned To||alexy => millerjv|
|2012-11-05 10:35||jcfr||Target Version||=> Slicer 4.2.1|
|2012-11-05 12:49||pieper||Note Added: 0007063|
|2012-11-06 09:50||jcfr||Relationship added||related to 0001690|
|2012-11-13 11:00||nicole||Note Added: 0007191|
|2012-11-13 11:31||millerjv||Note Added: 0007193|
|2012-11-14 06:44||millerjv||Note Added: 0007212|
|2012-11-14 06:45||millerjv||Note Added: 0007213|
|2012-11-14 06:46||millerjv||Status||assigned => feedback|
|2012-11-14 07:02||nicole||Note Added: 0007218|
|2012-11-14 08:10||millerjv||Note Added: 0007221|
|2012-11-16 06:38||jcfr||Note Added: 0007283|
|2012-11-16 06:38||jcfr||Status||feedback => resolved|
|2012-11-16 06:38||jcfr||Fixed in Version||=> Slicer 4.2.1|
|2012-11-16 06:38||jcfr||Resolution||open => fixed|
|2014-03-06 05:12||jcfr||Note Added: 0011003|
|2014-03-06 05:13||jcfr||Status||resolved => closed|