View Issue Details

IDProjectCategoryView StatusLast Update
0002753Slicer4Core: MRMLpublic2017-06-22 21:58
ReporterfedorovAssigned Toalexy 
PrioritynormalSeverityminorReproducibilitysometimes
Status assignedResolutionopen 
Product VersionSlicer 4.2.0 
Target VersionSlicer 4.7.0Fixed in Version 
Summary0002753: 3d view bounding box update is not triggered
Description

UpdateRASBounds() on 3d view bounding box appears to be called only when "Center 3d view" button is hit.

What is the expected behavior? Is it supposed to be invoked automatically when a new node shows up in the 3d view?

TagsNo tags attached.

Relationships

related to 0002752 closedfedorov FOV is not set properly in 3D viewer when using multivolume 
related to 0002341 resolvedhastings.greer Fix camera reset in vtkMRMLViewDisplayableManager 

Activities

alexy

alexy

2012-11-13 07:50

developer   ~0007185

Andrey, this is the expected behavior. We decided we dont want the view jump around when changes to the scene occur.

fedorov

fedorov

2012-11-13 08:07

developer   ~0007187

Alex, then we need to explain this to Ron, because it looks like this is not the behavior he expects. See related issue 0002752.

alexy

alexy

2012-11-13 10:04

developer   ~0007189

I looked at the code and there has never been a dynamic bbox adjustment in slicer4.

It may be a good idea to do it on volume load (or multi-volume load). To do it programmatically one can invoke vtkMRMLViewNode::ResetFocalPointRequestedEvent

fedorov

fedorov

2012-11-13 10:58

developer   ~0007190

Alex, I can add this to my code, but if it makes sense to do it on the volume load, maybe we should do this all the time a volume node is added to the scene, or somewhere in the DICOM module?

alexy

alexy

2012-11-13 11:30

developer   ~0007192

I suggest that you add it to your code, there should be no harm in this.
We can do it for load volume later if we decide to.

pieper

pieper

2012-11-14 09:33

administrator   ~0007222

Seems like we should have a method in the mrml application logic that invokes the ResetFocalPointRequestedEvent on all view nodes in the scene.

This could then be called whenever a displayable node is added to the scene (or possibly whenever a displayable is modified).

pieper

pieper

2014-03-07 06:41

administrator   ~0011335

Maybe there's a need for a lock option on the viewer.

alexy

alexy

2014-05-16 06:54

developer   ~0011868

Since there seems to be no agreement on the exact requirements moving the target release to 4.5

lassoan

lassoan

2017-06-22 21:58

developer   ~0014913

Bill implemented automatic re-centering and it had many side effects so we reverted to the current manual method. Behavior of a fully automatic method is unpredictable when nodes are moved around a lot (especially in IGT) and so many things can alter bounding box of displayable nodes that even observing all those events may have significant performance impact.

However, it could make sense to reset the FOV for example when a volume is propagated to slice views (e.g., when a volume is loaded).

Issue History

Date Modified Username Field Change
2012-11-13 04:08 fedorov New Issue
2012-11-13 04:08 fedorov Status new => assigned
2012-11-13 04:08 fedorov Assigned To => alexy
2012-11-13 04:08 fedorov Relationship added related to 0002752
2012-11-13 07:50 alexy Note Added: 0007185
2012-11-13 07:50 alexy Status assigned => feedback
2012-11-13 08:07 fedorov Note Added: 0007187
2012-11-13 10:04 alexy Note Added: 0007189
2012-11-13 10:58 fedorov Note Added: 0007190
2012-11-13 11:30 alexy Note Added: 0007192
2012-11-14 09:33 pieper Note Added: 0007222
2012-11-14 09:33 pieper Target Version => Slicer 4.3.0
2013-09-02 19:08 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-09-03 03:45 fedorov Status feedback => assigned
2014-03-07 06:41 pieper Note Added: 0011335
2014-05-16 06:54 alexy Note Added: 0011868
2014-05-16 06:54 alexy Target Version Slicer 4.4.0 => Slicer 4.5.0-1
2015-11-02 11:27 jcfr Target Version Slicer 4.5.0-1 => Slicer 4.6.0
2016-06-16 19:18 jcfr Relationship added related to 0002341
2016-10-12 03:55 jcfr Target Version Slicer 4.6.0 => Slicer 4.7.0
2017-06-22 21:58 lassoan Note Added: 0014913