View Issue Details

IDProjectCategoryView StatusLast Update
0002827Slicer4Core: Extensionspublic2017-09-27 15:10
ReporternicoleAssigned Tojcfr 
PrioritylowSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
PlatformlinuxOSOS Version
Product VersionSlicer 4.2.1 
Target VersionbacklogFixed in Version 
Summary0002827: Reporting module AdditionalLauncherSettings.ini not regenerated with change in version
Description

Trying to debug a failing test:
http://slicer.cdash.org/testDetails.php?test=3213505&build=51696
with notes here:
https://github.com/fedorov/Reporting/issues/37

I found that the AdditionalLauncherSettings.ini file in my extension module build directory didn't get regenerated with the bump in Slicer version from 4.1 to 4.2, I had to delete the .ini file and rerun make.

Additional Information

Even with the correct paths in the .ini file the test is still failing since both the Reporting module and the LabelToDICOMSEGConverter module aren't appearing in the slicer.modules list, they've not been loaded/imported. This is probably due to the LabelToDICOMSEGConverter being in a subdirectory of the Reporting module, as the Reporting round trip test is able to find the reporting module.

ls -1b Reporting-build/lib/Slicer-4.2/qt-scripted-modules/*.pyc
8 Reporting-build/lib/Slicer-4.2/qt-scripted-modules/DICOMSegmentationPlugin.pyc
16 Reporting-build/lib/Slicer-4.2/qt-scripted-modules/FindLabelToDICOMSEGConverterSelfTest.pyc
16 Reporting-build/lib/Slicer-4.2/qt-scripted-modules/LabelToDICOMSEGConverter.pyc
24 Reporting-build/lib/Slicer-4.2/qt-scripted-modules/LabelToDICOMSEGConverterSelfTest.pyc
24 Reporting-build/lib/Slicer-4.2/qt-scripted-modules/ReportingSelfTest.pyc

TagsNo tags attached.

Activities

jcfr

jcfr

2013-01-08 11:35

administrator   ~0007629

A possible solution would be to add "vtkSlicerVersionConfigure" as an extra dependency to the custom command in charge of generating the AdditionalLauncherSettings, it should solve the problem.

See https://github.com/Slicer/Slicer/blob/master/Extensions/CMake/SlicerBlockAdditionalLauncherSettings.cmake#L38

That said, simply reconfiguring and rebuilding your module should also do the job. Do we want to complexify the build system or is it enough to assume the developer should reconfigure his module ...

nicole

nicole

2013-01-15 06:08

administrator   ~0007672

I'm relatively certain that the extension module had already been reconfigured once before I moved aside the .ini file in order to force it to be regenerated, but I'd have to try and recreate the issue.
I'd vote for adding the extra dependency, since the Slicer version number can change and the factory will fail to build new versions of modules if they're not reconfiguring modules every night.

jcfr

jcfr

2013-01-16 05:58

administrator   ~0007683

Since the build tree on the factory is deleted every night, the chance of having problem on that side is relatively small.

That said, adding an extra dependency wouldn't hurt. I will set the priority of the issue to low.

Thanks
Jc

Issue History

Date Modified Username Field Change
2012-12-13 12:42 nicole New Issue
2012-12-13 12:42 nicole Status new => assigned
2012-12-13 12:42 nicole Assigned To => jcfr
2013-01-08 11:35 jcfr Note Added: 0007629
2013-01-08 11:35 jcfr Status assigned => feedback
2013-01-15 06:08 nicole Note Added: 0007672
2013-01-16 05:58 jcfr Note Added: 0007683
2013-01-16 05:59 jcfr Priority normal => low
2013-01-16 05:59 jcfr Status feedback => assigned
2013-01-16 05:59 jcfr Target Version Slicer 4.2.3 => Slicer 4.3.0
2013-08-30 13:05 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2014-07-29 10:07 jcfr Target Version Slicer 4.4.0 => Slicer 4.5.0-1
2015-11-02 09:31 jcfr Target Version Slicer 4.5.0-1 => Slicer 4.5.1
2016-10-12 02:26 jcfr Target Version Slicer 4.5.1 => Slicer 4.7.0
2017-09-27 15:10 lassoan Target Version Slicer 4.7.0 => backlog