Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantics of 4D volumes are undefined #3079

Closed
slicerbot opened this issue Mar 12, 2020 · 2 comments
Closed

Semantics of 4D volumes are undefined #3079

slicerbot opened this issue Mar 12, 2020 · 2 comments
Assignees
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@lassoan
Copy link
Contributor

lassoan commented Mar 20, 2020

This is also important for conversion between RAS/LPS vector volumes. For example, if a vector volume contain a spatial vector field then the values should be transformed from RAS to LPS when written to file. However, if vectors contain RGB values then the value should not be transformed when written to file.

@lassoan lassoan added this to the Slicer 4.11.0 milestone Mar 20, 2020
@lassoan lassoan added Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality labels Mar 20, 2020
@lassoan lassoan self-assigned this Mar 26, 2020
@lassoan
Copy link
Contributor

lassoan commented Jul 2, 2021

This is addressed in recent Slicer versions: vtkMRMLVolumeNode stores VoxelVectorType. Spatial voxel vectors are automatically converted between RAS/LPS when reading/writing.

This is probably sufficient, because we have special volume node subclasses for dwi and dti volumes.

@lassoan lassoan closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Development

No branches or pull requests

2 participants