View Issue Details

IDProjectCategoryView StatusLast Update
0003126Slicer4Module ModelMakerpublic2015-11-04 10:37
ReporterdpaceAssigned Tomillerjv 
PrioritynormalSeverityfeatureReproducibilityalways
Status feedbackResolutionreopened 
Product VersionSlicer 4.2.2-1 
Target VersionFixed in VersionSlicer 4.6.0 
Summary0003126: Model maker should create new model hierarchy if it doesn't exist
Description

It would be very nice if the model maker module created a new model hierarchy automatically if it did not exist. I often forget to create the model hierarchy (it is pretty buried in the UI), wait to generate the model, and then get nothing created.

TagsNo tags attached.

Activities

nicole

nicole

2013-05-22 12:39

administrator   ~0008666

It would be great, but the current CLI module logic doesn't support it, so it's more a feature request than a tweak.
I think it would have to be another flag on an output data type to auto create a node before calling the CLI, but I'm not sure that would work with the current infrastructure. In this case the hierarchy node has to be passed via a scene file to the model maker so that all the models can be read back in (as that was the only way to support multiple output models).

jcfr

jcfr

2015-11-03 20:33

administrator   ~0013544

This has been fixed in r23976

ENH: Jim Miller's fix for enabling Hierarchy sub-scenes to be passed to CLI
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23976

nicole

nicole

2015-11-04 05:12

administrator   ~0013553

This issue is concerning the user interaction with the model maker CLI: they have to manually create a new model hierarchy node or it won't run. The revision that @jcfr referenced shows a top level check of if hierarchy node exists then do the passing, and that would be a place to investigate if we can auto-create the hierarchy node if it is null.

nicole

nicole

2015-11-04 10:37

administrator   ~0013562

Quick look at the current state: there isn't a good way to tell that we're missing a model hierarchy node when it's required at the cli logic level.

The model maker apply button wasn't active when I did the following:
load a label map called seg
enter model maker
When I created a new model hierarchy, the apply button became active, but the GUI reset the input volume node back to none and I had to reset it to seg.
To investigate: required arguments vs active Apply button.

There is also still an old interface being referenced in the error message (references to Slicer 3 and scene import):


ERROR: no model scene defined! Using CDHEF_vtkMRMLLabelMapVolumeNodeB.mrml
WARNING: If you started Model Maker from the Slicer3 GUI, the models will NOT be loaded automatically.
You must use File->Import Scene CDHEF_vtkMRMLLabelMapVolumeNodeB.mrml to see your models (don't use Load or it will close your current scene).


Model scene file doesn't exist yet: CDHEF_vtkMRMLLabelMapVolumeNodeB.mrml
Error: no model hierarchy node at ID "", creating one

Issue History

Date Modified Username Field Change
2013-05-22 12:30 dpace New Issue
2013-05-22 12:30 dpace Status new => assigned
2013-05-22 12:30 dpace Assigned To => nicole
2013-05-22 12:39 nicole Note Added: 0008666
2013-05-22 12:40 nicole Assigned To nicole => millerjv
2013-05-22 12:45 dpace Severity tweak => feature
2015-11-03 20:32 jcfr Relationship added related to 0002906
2015-11-03 20:33 jcfr Relationship deleted related to 0002906
2015-11-03 20:33 jcfr Note Added: 0013544
2015-11-03 20:33 jcfr Status assigned => resolved
2015-11-03 20:33 jcfr Fixed in Version => Slicer 4.5.0-1
2015-11-03 20:33 jcfr Resolution open => fixed
2015-11-04 05:12 nicole Note Added: 0013553
2015-11-04 05:12 nicole Status resolved => feedback
2015-11-04 05:12 nicole Resolution fixed => reopened
2015-11-04 05:15 jcfr Fixed in Version Slicer 4.5.0-1 => Slicer 4.6.0
2015-11-04 10:37 nicole Note Added: 0013562