Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externally set application home to CLIModuleFactoryHelper #3411

Closed
slicerbot opened this issue Mar 13, 2020 · 4 comments · Fixed by #4911
Closed

Externally set application home to CLIModuleFactoryHelper #3411

slicerbot opened this issue Mar 13, 2020 · 4 comments · Fixed by #4911
Assignees
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@lassoan
Copy link
Contributor

lassoan commented Mar 20, 2020

@jcfr is this still relevant?

@lassoan
Copy link
Contributor

lassoan commented Apr 30, 2020

@jcfr please close or retarget

@lassoan lassoan added this to the Backlog milestone Apr 30, 2020
@jcfr
Copy link
Member

jcfr commented May 5, 2020

Closing. Static version of the qSlicerCLIModuleFactoryHelper::isInstalled()/isBuiltIn() methods accepting slicerHome as parameter are already available in qSlicerUtils

And if for some reason we need to call qSlicerCLIModuleFactoryHelper::modulePaths without already having an instance of qSlicerCoreApplication running, we can revisit this.

In the meantime, I will commit a change removing the Q_ASSERT from qSlicerCoreApplication

@jcfr
Copy link
Member

jcfr commented May 5, 2020

Thanks for the review and integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants