View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003761||Slicer4||Module Markups||public||2014-07-03 20:08||2017-06-10 08:51|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||Slicer 4.4.0||Fixed in Version||Slicer 4.4.0|
|Summary||0003761: Markups: test_MarkupsInCompareViewersSelfTest1 is failing|
With either VTKv5 or VTKv5, the test is failing.
As illustrated in , it seems that commit r23325  caused the test to fail.
// ------------------------- "Volume" Reader has successfully read the file "/tmp/RemoteIO/MR-head.nrrd" Load finished Placed 3 fiducials ERROR: In /home/kitware/Dashboards/Continuous/Slicer4-0-build-64bits-QT4.8.5-PythonQt-With-Tcl-CLI-Release-continuous/VTKv6/Rendering/Core/vtkRenderer.cxx, line 1296 vtkOpenGLRenderer (0x5c1ce90): WorldToView: no active camera, cannot compute world to view, returning 0,0,0 ERROR: In /home/kitware/Dashboards/Continuous/Slicer4-0-build-64bits-QT4.8.5-PythonQt-With-Tcl-CLI-Release-continuous/VTKv6/Rendering/Core/vtkRenderer.cxx, line 1296 vtkOpenGLRenderer (0x5c1ce90): WorldToView: no active camera, cannot compute world to view, returning 0,0,0 // -------------------------
|Tags||No tags attached.|
Test is also failing with VTKv6.
This crash returns when events are out of synch in changing layouts. Steve proposed a patch once before in  but it didn't get into VTK via gerrit. I'd like to propose patching our VTK to avoid the crash and to give an error message instead, and if it works well with our nightly tests to submit it to gerrit. The vtkOpenGLRenderer is giving an error message instead of crashing so this patch matches that handling of the non active camera case.
@Nicole: Sounds like a plan. Out of curiosity, I couldn't find the patch Steve submitted on Gerrit , do you have the link ? In parallel, I think it would make sense to re-submit to Gerrit.
It didn't get submitted to gerrit, just posted as a diff on the bug report.
Thanks for moving forward with this.
Pull request on Slicer/VTK would be great. (make sure to base the pull request on top of "slicer-4.3-v6.1.0" 
The best way to get it integrated into VTK6 is to submit a patch on Gerrit. Let me know if you have any issue with this. See http://www.vtk.org/Wiki/VTK
Slicer/VTK pull request:
Partially fixed in r23462. The doesn't crash anymore but still report VTK errors. See below.
$ git shortlog 4d7abb2..169b37b
This commit prevent the test from failing but it doesn't avoid the
svn 23493  checks for active cameras before repositioning or enabling the fiducial widget or handles. The test is no longer printing error messages and the updates get called again to update once the renderer has been set up properly.
Import 2017-06-07 23:51:09: master c7b22bdd
|BUG: test for active camera before enabling fiducials
Removes the error message that world to view and view to world
can't compute result due to a missing active camera. Delaying
setting the handles and widgets to be enabled if there's
no active camera defined on their renderers seems to work well
since the next time through the update code once the layout
has stabilised and the renderers are updated, the seeds
will get positioned and enabled.
git-svn-id: http://svn.slicer.org/Slicer4/trunk@23493 3bd1e089-480b-0410-8dfb-8563597acbee
|mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager2D.cxx||Diff File|
|mod - Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsFiducialDisplayableManager2D.cxx||Diff File|
|2014-07-03 20:08||jcfr||New Issue|
|2014-07-03 20:08||jcfr||Status||new => assigned|
|2014-07-03 20:08||jcfr||Assigned To||=> nicole|
|2014-07-03 20:08||jcfr||Target Version||=> Slicer 4.4.0|
|2014-07-03 20:10||jcfr||Relationship added||has duplicate 0003762|
|2014-07-03 20:10||jcfr||Description Updated|
|2014-07-09 12:56||nicole||Note Added: 0012159|
|2014-07-09 12:57||nicole||Note Edited: 0012159|
|2014-07-09 12:57||nicole||Relationship added||related to 0001690|
|2014-07-11 04:50||jcfr||Note Added: 0012161|
|2014-07-11 06:41||nicole||Note Added: 0012168|
|2014-07-12 16:33||jcfr||Note Added: 0012171|
|2014-07-14 07:12||nicole||Note Added: 0012177|
|2014-07-18 00:06||jcfr||Note Added: 0012191|
|2014-07-29 14:40||nicole||Note Added: 0012281|
|2014-07-29 14:40||nicole||Status||assigned => resolved|
|2014-07-29 14:40||nicole||Fixed in Version||=> Slicer 4.4.0|
|2014-07-29 14:40||nicole||Resolution||open => fixed|
|2014-08-29 07:48||jcfr||Status||resolved => closed|
|2017-06-10 08:51||Changeset attached||=> Slicer master c7b22bdd|