Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous DICOM retrieval #3794

Closed
slicerbot opened this issue Mar 13, 2020 · 7 comments
Closed

Asynchronous DICOM retrieval #3794

slicerbot opened this issue Mar 13, 2020 · 7 comments
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@sjh26
Copy link
Contributor

sjh26 commented Mar 18, 2020

This has been added

@sjh26 sjh26 closed this as completed Mar 18, 2020
@lassoan
Copy link
Contributor

lassoan commented Mar 18, 2020

Background DICOM import is implemented (retrieval is not yet). This may become more important when we implement launching of Slicer from web browser.

@lassoan lassoan reopened this Mar 18, 2020
@lassoan lassoan added Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality labels Mar 18, 2020
@lassoan lassoan added this to the Backlog milestone Mar 18, 2020
@pieper
Copy link
Member

pieper commented Mar 18, 2020

It's true that if you use the query / retrieve in the dicom module it's not async, but if you run the listener and push from the scanner or pacs it is async, so this is definitely a backlog issue, if we leave it open.

@lassoan
Copy link
Contributor

lassoan commented Mar 18, 2020

Retrieve data using DICOMweb protocol is extremely slow, and this is how many people would like to use Slicer (click image in web browser and open it in desktop Slicer), so we must make this data retrieve asynchronous.

@pieper
Copy link
Member

pieper commented Mar 18, 2020

I was talking about DIMSE, since the original issue is from 2014 it probably refers to that.

Regarding DICOMweb, I agree it's slow. dicomweb-client uses a sync version of requests so it cannot overlap network operations. I looked into async python for requests, but it would need to be integrated with Qt. Another option would be to use Qt for event driven downloads instead python.

@pieper
Copy link
Member

pieper commented Mar 18, 2020

Probably we should start a new dicomweb issue and close this one.

@lassoan
Copy link
Contributor

lassoan commented Mar 18, 2020

OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Small, non-essential improvements or fixes Type: Enhancement Improvement to functionality
Development

No branches or pull requests

4 participants