Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlicerConfig: Rewrite comment about CMAKE_OSX_* and ConfigurePrerequisites #4063

Closed
slicerbot opened this issue Mar 13, 2020 · 4 comments
Closed

SlicerConfig: Rewrite comment about CMAKE_OSX_* and ConfigurePrerequisites #4063

slicerbot opened this issue Mar 13, 2020 · 4 comments
Assignees
@jcfr
Milestone
Backlog

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
@lassoan
Copy link
Contributor

lassoan commented Mar 21, 2020

@jcfr is this still relevant?

@lassoan
Copy link
Contributor

lassoan commented Apr 30, 2020

@jcfr please close or retarget

@lassoan lassoan added this to the Backlog milestone Apr 30, 2020
@jcfr
Copy link
Member

jcfr commented May 5, 2020 •
edited

Related to #4575

@jcfr
Copy link
Member

jcfr commented May 5, 2020

Closing. Relevant comments are already present in SlicerConfig.cmake

Slicer/CMake/SlicerConfig.cmake.in

Lines 10 to 43 in 88bff56

#
# When manually building extension on MacOSX, in addition to the usual configure
# option (CMAKE_BUILD_TYPE, ...), the developer is also expected to
# configure it passing the variables:
# CMAKE_OSX_ARCHITECTURES
# CMAKE_OSX_DEPLOYMENT_TARGET
# CMAKE_OSX_SYSROOT
# The value of these variables should match the one used to
# configure the associated Slicer build tree. These values can be
# retrieved looking at the CMakeCache.txt file located in the Slicer
# build tree.
#
# To simplify the task of manually building out-of-source modules or extensions,
# the developer could include the following statement at the top of both the main
# CMakeLists.txt of the extension and also at the top of each module CMakeLists.txt
# bundled within the extension.
# Doing so will ensure that either the extension or each bundled module could be
# built in a standalone fashion very easily without passing extra option
# at configure time:
#
# find_package(Slicer COMPONENTS ConfigurePrerequisites REQUIRED)
#
# project(Foo)
#
# [...]
#
# find_package(Slicer REQUIRED)
# include(${Slicer_USE_FILE})
# [...]
# Extension support can be disabled by either
# (1) setting Slicer_DONT_USE_EXTENSION to TRUE or
# (2) calling find_package(Slicer COMPONENTS NoExtensionSupport [...] REQUIRED)

@jcfr jcfr closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jcfr @lassoan @slicerbot