View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004344||Slicer4||Core: CLI infrastructure||public||2017-02-13 19:43||2018-05-29 23:24|
|Target Version||backlog||Fixed in Version|
|Summary||0004344: Create a DICOM Series module makes invalid DICOM|
Using the DICOM export feature, you can end up with strings that have embedded null characters. This can cause some dicom parsers to (correctly) reject the data. The result of dciodvfy is pasted in the info below.
The underlying issue appears to be with itk, because the windowCenter and windowWidth fields are both set with the identical code, but in the output one has a null character at the end and the other does not.
0000017 Slicer (master=)$ ~/Downloads/dicom3tools/dciodvfy /tmp/xx/dicom/1.2.8188.8.131.5280043.2.1125.1.34027065691713096181869243555208536/1.2.8184.108.40.20680043.2.1125.1.60570920072252354871500178658621494/1.2.8220.127.116.1180043.2.1125.1.70748948830687791038514864791546742 | less
Error - Value invalid for this VR - (0x0008,0x0030) TM Study Time TM - Trailing character invalid for this VR = '' (0)
|Tags||No tags attached.|
ITK issue reported: https://issues.itk.org/jira/browse/ITK-3523
@pieper can you update this issue and let us know if Andras patcher fixes this issue?
If it does, maybe patcher should be done automatically on DICOM export from Slicer?
@fedorov you are right, the patcher fixes the trailing null characters!
Some of the other issues remain, but they aren't problematics for my use case.
I agree that running the patcher as a step in the export process is a good workaround.
$ ~/Downloads/dicom3tools/dciodvfy /tmp/slicer-export-patched/pa000/st000/se000/mr100.dcm
It is probably just a matter of adding these lines (a subset of the ones from )
To this code:
Reminder sent to: lassoan
Hi @lassoan can you look at the suggested use of the DICOMPatcher in the notes here and suggest if the patcher should be used this way (i.e. if other rules should be used?) Thanks.
Steve, great news!
Does QuantitativeReporting work with this dataset after you patch it?
@fedorov - yes, this fixes QuantitativeReporting as well!
I think that adding this as a suggestion in an FAQ for the QR module would be good.
Good idea, thanks! I added an issue here: https://www.gitbook.com/book/qiicr/quantitativereporting-guide/discussions/1
I personally never used DICOM patcher, so wanted to look into it before adding that as a suggestion.
Retargeting stale issues to backlog.
|2017-02-13 19:43||pieper||New Issue|
|2017-02-13 19:43||pieper||Status||new => assigned|
|2017-02-13 19:43||pieper||Assigned To||=> jcfr|
|2017-02-13 19:48||pieper||Note Added: 0014331|
|2017-02-16 11:24||fedorov||Relationship added||related to 0003255|
|2017-02-16 11:29||fedorov||Note Added: 0014339|
|2017-02-16 11:59||pieper||Note Added: 0014340|
|2017-02-16 12:03||pieper||Note Added: 0014341|
|2017-02-16 12:07||pieper||Note Added: 0014342|
|2017-02-16 12:16||fedorov||Note Added: 0014343|
|2017-02-16 12:21||pieper||Note Added: 0014344|
|2017-02-16 12:28||fedorov||Note Added: 0014345|
|2018-05-29 23:24||lassoan||Target Version||=> backlog|
|2018-05-29 23:24||lassoan||Note Added: 0015781|