View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004408||Slicer4||Module Models||public||2017-08-04 09:18||2018-03-20 12:40|
|Product Version||Slicer 4.7.0|
|Target Version||Slicer 4.7.0||Fixed in Version||Slicer 4.7.0|
|Summary||0004408: Save coordinate system in surface mesh file|
Slicer saves mesh in RAS coordinate system, while most other software use LPS.
It would be also good to add a file IO option so that the user could choose orientation (auto, RAS, LPS).
Currently supported file formats: (.vtk .vtp .vtu .g .byu .stl .ply .orig"
See details in this discussion:
|Tags||No tags attached.|
Is it something you plan on fixing for the release ?
In 4.7 I only plan to add saving of the coordinate space name (hardcoded to RAS).
In the next major release we can change Slicer to save in LPS by default. In a few years we can change Slicer to read as LPS by default (if no coordinate space is specified in the file) - by then there should not be too many legacy files around.
Partial fix is implemented in https://github.com/Slicer/Slicer/pull/798
Discussion on github:
Steps 1 and 2 make a lot of sense and there's no reason not to do that.
Yes, step 3 and 4 may cause troubles so probably a few year transition time is preferable.
Merged in r26398. Future steps will be discussed in https://issues.slicer.org/view.php?id=4445
It looks like current VTK STL reader cannot read the comment field. It should be easy to add, as if the files starts with "solid" then it is an ASCII file and you just need to read till the end of the line to get the comment field. If it does not start with "solid" then you read the 80-character header that contains the comment. See details here: https://en.wikipedia.org/wiki/STL_%28file_format%29
After the STL reader is capable of reading the comment field, it can be done very quickly. If you take care of the vtkSTLReader then I can implement Slicer part (ability to read/write as LPS/RAS).
Alexis, I've implemented the necessary changes in VTK:
I would appreciate if you could help facilitating review and integration of the changes.
|2017-08-04 09:18||lassoan||New Issue|
|2017-09-26 10:19||jcfr||Status||new => acknowledged|
|2017-09-26 10:20||jcfr||Status||acknowledged => feedback|
|2017-09-26 10:20||jcfr||Note Added: 0015127|
|2017-09-26 17:14||lassoan||Note Added: 0015140|
|2017-09-26 17:14||lassoan||Status||feedback => new|
|2017-09-26 17:15||lassoan||Assigned To||=> lassoan|
|2017-09-26 17:15||lassoan||Status||new => assigned|
|2017-09-27 09:16||lassoan||Note Added: 0015141|
|2017-09-27 19:00||lassoan||Note Added: 0015210|
|2017-09-27 19:04||lassoan||Relationship added||related to 0004445|
|2017-09-27 19:05||lassoan||Status||assigned => resolved|
|2017-09-27 19:05||lassoan||Resolution||open => fixed|
|2017-09-27 19:05||lassoan||Fixed in Version||=> Slicer 4.7.0|
|2017-09-27 19:05||lassoan||Note Added: 0015211|
|2018-02-21 11:15||alexis.girault||Note Added: 0015516|
|2018-02-21 11:16||alexis.girault||Note Edited: 0015516||View Revisions|
|2018-02-21 11:27||lassoan||Note Added: 0015517|
|2018-03-02 11:00||jcfr||Status||resolved => closed|
|2018-03-20 12:40||lassoan||Note Added: 0015577|