View Issue Details

IDProjectCategoryView StatusLast Update
0004485Slicer4Core: Base Codepublic2017-12-06 12:00
ReporterinortonAssigned Tojcfr 
PrioritynormalSeverityminorReproducibilityhave not tried
Status assignedResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0004485: Unsafe call in vtkMRMLModelDisplayNode::GetOutputMesh
Description

These lines of vtkMRMLModelDisplayNode::GetOutputMesh are potentially unsafe:

https://github.com/Slicer/Slicer/blob/57b1022969917d39d73958983426b250af93e4d2/Libs/MRML/Core/vtkMRMLModelDisplayNode.cxx#L220-L221

 vtkAlgorithm* producer =  outputConnection? outputConnection->GetProducer() : 0;
  producer->Update();

If outputConnection->GetProducer is considered an invariant then we should probably just assert(producer) rather than using the ternary.

(I don't have a crash reproducer, simply noticed this while working through something else)

TagsNo tags attached.

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2017-12-06 12:00 inorton New Issue
2017-12-06 12:00 inorton Status new => assigned
2017-12-06 12:00 inorton Assigned To => jcfr