View Issue Details

IDProjectCategoryView StatusLast Update
0004547Slicer4Module VolumeRenderingpublic2018-05-03 15:33
ReporterpinterAssigned Topinter 
PrioritynormalSeverityminorReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionSlicer 4.9.0 
Target VersionSlicer 4.9.0Fixed in VersionSlicer 4.9.0 
Summary0004547: Volume rendering with ROI cropping - MRML scene backwards compatibility issue
Description

I’ve set up volume rendering with cropping and an ROI in a particular spot. I can reload this into the April 15 nightly and everything works great. When I load the same setup into the 5-2 nightly, nothing shows up in the volume render window unless I turn off cropping.

If I make a new annotation ROI and delete the old one, cropping works fine.

Steps To Reproduce

If you have an old nightly (4-15) around, do this:

  1. Run old nightly
  2. Load CTACardio
  3. Turn on volume rendering
  4. Turn on cropping
  5. Crop a little
  6. Save scene
  7. Run new nightly
  8. Load file from old nightly
  9. Observe - no volume rendered.
Additional Information

https://discourse.slicer.org/t/volume-rendering-crop-not-working-in-latest-nightlies-when-loading-older-file/2749

TagsNo tags attached.

Activities

pinter

pinter

2018-05-03 14:18

developer   ~0015695

After some diagnosis:

  1. The error is reproducible as described
  2. If after loading the scene, we load the ROI separately from the acsv file, and select it as ROI for the volume in the Volume rendering module's input section, then it's displayed properly
  3. If we clone the node that we loaded with the scene using subject hierarchy's clone action, and select it as ROI, then the rendering does not show up
  4. The properties of the good and bad nodes are identical
pinter

pinter

2018-05-03 15:04

developer   ~0015698

The difference is here
https://github.com/Slicer/Slicer/blob/master/Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.cxx#L594

pinter

pinter

2018-05-03 15:29

developer   ~0015699

Discourse thread for reference: https://discourse.slicer.org/t/volume-rendering-crop-not-working-in-latest-nightlies-when-loading-older-file/2749

pinter

pinter

2018-05-03 15:33

developer   ~0015700

Fixed in https://github.com/Slicer/Slicer/commit/1443b336855a4885fc67e9e4497d3fea25e58e2e

Issue History

Date Modified Username Field Change
2018-05-03 10:28 pinter New Issue
2018-05-03 10:28 pinter Status new => assigned
2018-05-03 10:28 pinter Assigned To => pinter
2018-05-03 14:18 pinter Note Added: 0015695
2018-05-03 15:04 pinter Note Added: 0015698
2018-05-03 15:29 pinter Note Added: 0015699
2018-05-03 15:33 pinter Status assigned => resolved
2018-05-03 15:33 pinter Resolution open => fixed
2018-05-03 15:33 pinter Fixed in Version => Slicer 4.9.0
2018-05-03 15:33 pinter Note Added: 0015700