New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup datastore #4602
Comments
While datastore works, it breaks the extension manager (open DataStore module, close the window; open Extension Manager => instead of "Install" button, "Download" button is displayed and it downloads the extension instead of installing it). Also, it is clear that there will be no Midas communities (there are many alternative, more open and more popular data repositories) and at some point the Midas server will be retired. @Slicer/slicer-core What do you think about removing DataStore module, moving data to into a github repository and add links to important data sets (atlas collection, registration case library, maybe a few more nicer data sets) to SampleData module? We could use the existing SlicerTestingData or a new SlicerDataStore github repository. |
I like the idea of migrating from midas to github for this. I'm not sure what you mean by removing the SampleData module - did you mean DataStore? If so, yes. |
Yes, sorry I meant removing DataStore module. |
That makes sense. Also, if there is a strong push to keep similar functionality we could modify the DataStore module and leverage GitHub API to upload asset. That said, I would prefer to avoid the added complexity and associated maintenance cost.
That is a tough questions. Before answering, may be we should define the role of each. Here is an attempt:
Now for practical reason, we could organize all data under the same repository:
|
I think it would be easier to have two separate repositories, as we would not need to migrate SlicerTestingData, it would allow using the exact same script for managing data (upload scripts, various download scripts implemented in Python and CMake, etc.), and the download URLs would remain simpler (https://github.com/Slicer/SlicerTestingData/releases/download/MD5/nnnn). |
Agree with you. Then, should we name it
|
SlicerDataStore sounds a bit more appropriate to me, as we move DataStore content there, and some data sets, such as atlases and registration case library images, are more than just some "sample" data sets. |
The repository for the DataStore module is https://github.com/Slicer/Slicer-DataStore, I will update its README and archive the repository. In the meantime, I just created a repository called SlicerDataStore (along with README file including a Maintenance and an History section). See https://github.com/Slicer/SlicerDataStore |
README has been updated (addition of History section), and the repository has been archived. see https://github.com/Slicer/Slicer-DataStore |
All files from the DataStore collection (see here) are being downloaded. I wrote a small script leveraging Soon I will upload the files as release assets along with the metadata (for historical reference) into https://github.com/Slicer/SlicerDataStore Once this is completed, I will submit a PR to update the download links in Slicer and remove the DataStore module from Slicer. Later, we could still revisit and have am updated DataStore module allowing to directly upload MRB as release asset ... |
Since it appears the download links have been updated in 3ae8c31, is the next step to remove the DataStore module? Lines 325 to 333 in a12d8d3
|
There are lots of datasets in Data Store that has not been added to SampleData module yet. |
As discussed in the past, all datasets have been added here: https://github.com/Slicer/SlicerDataStore/releases Next step would be generate a static github page to organize them in categories along with relevant metadata stored in the file |
@lassoan and I are currently finalizing this |
In March 2020, the Slicer community decided (see issue [1]) to retire the DataStore module and instead store the corresponding data files as GitHub release assets into the Slicer/SlicerDataStore [2] GitHub project. In September 2021, the Slicer legacy extensions catalog has been updated (see [3]) to include the `/midas3/slicerdatastore` and `/midas3/slicerdatastore/user/login` endpoints displaying instructions referencing the GitHub release assets. Finally, in April 2022, the module was completely removed. [1]: Slicer#4602 [2]: https://github.com/Slicer/SlicerDataStore [3]: Slicer#5845
In March 2020, the Slicer community decided (see issue [1]) to retire the DataStore module and instead store the corresponding data files as GitHub release assets into the Slicer/SlicerDataStore [2] GitHub project. In September 2021, the Slicer legacy extensions catalog has been updated (see [3]) to include the `/midas3/slicerdatastore` and `/midas3/slicerdatastore/user/login` endpoints displaying instructions referencing the GitHub release assets. Finally, in April 2022, the module was completely removed. [1]: Slicer#4602 [2]: https://github.com/Slicer/SlicerDataStore [3]: Slicer#5845
In March 2020, the Slicer community decided (see issue [1]) to retire the DataStore module and instead store the corresponding data files as GitHub release assets into the Slicer/SlicerDataStore [2] GitHub project. In September 2021, the Slicer legacy extensions catalog has been updated (see [3]) to include the `/midas3/slicerdatastore` and `/midas3/slicerdatastore/user/login` endpoints displaying instructions referencing the GitHub release assets. Finally, in April 2022, the module was completely removed. [1]: #4602 [2]: https://github.com/Slicer/SlicerDataStore [3]: #5845
Closing. All datasets have been archived in this project. See https://github.com/Slicer/slicer.kitware.com-midas3-archive#readme |
This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
The text was updated successfully, but these errors were encountered: