Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CDash project from Slicer4 to SlicerStable #4644

Closed
slicerbot opened this issue Mar 13, 2020 · 7 comments · Fixed by #6062
Closed

Rename CDash project from Slicer4 to SlicerStable #4644

slicerbot opened this issue Mar 13, 2020 · 7 comments · Fixed by #6062
Assignees
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@lassoan lassoan assigned lassoan and jcfr and unassigned lassoan Mar 26, 2020
@jamesobutler
Copy link
Contributor

@jcfr Did CDash developers ever answer your question about being able to rename a project?

@jcfr
Copy link
Member

jcfr commented Nov 29, 2021

Did CDash developers ever answer your question about being able to rename a project?

Indeed, there are few tasks to consider that would also require coordinating between different people:

For completeness, here is the comment of @zackgalbreath from Jan 17, 2019, 11:26 PM

As you probably noticed, the "edit project" page in CDash doesn't present you with an option to rename your project. That being said, I'm pretty sure that the project name only exists in a single place in the database, so it should be as simple as updating that single row.

My concern with doing this is that we will also need to update your CTestConfig.cmake file at the same time. Otherwise slicer.cdash.org won't know what to do with submissions to "Slicer4" after we've renamed the project to "SlicerStable".

@jcfr
Copy link
Member

jcfr commented Nov 29, 2021

Alternatively, we could simply create a new project called SlicerStable and once we have released Slicer 5:

  • delete the older Slicer4 project
  • setup a rewrite rule in Apache to have the URL with Slicer4 rewritten to the one with SlicerStable

That way creating the rewrite rule is not in the critical path to ensure the submission associated with Stable extension still work as expected.

Since (1) keeping the historical build results is not relevant (they are only kept around for a limited time - details below), (2) duplicating the configuration is easy enough, this would be a reasonable path forward.

@lassoan @sjh26 @jamesobutler What do you think ?

Slicer4 CDash configuration ( Miscellaneous tab)

image

@lassoan
Copy link
Contributor

lassoan commented Nov 29, 2021

We could leave Slicer4 as is, and add a new SlicerStable project. This can be done anytime, but if we want to avoid confusion then it should be done before Slicer5 is released.

@jamesobutler
Copy link
Contributor

Yes, a new SlicerStable project is fine with me to be done prior to Slicer5 released. Then Slicer4 can be kept around for some time for debugging when certain things maybe began to fail, and then after awhile when we don't need to look back at the old results, then remove the Slicer4 project.

@lassoan
Copy link
Contributor

lassoan commented Nov 29, 2021

Oh, @jcfr beat me by a few seconds!

I agree with adding a new SlicerStable project.

Why do we need the redirect? CTestConfig.cmake in extensions contain set(CTEST_DROP_LOCATION "/submit.php?project=Slicer4") but somehow they submit to SlicerPreview project, too.

@jcfr
Copy link
Member

jcfr commented Dec 1, 2021

Why do we need the redirect? CTestConfig.cmake in extensions contain set(CTEST_DROP_LOCATION "/submit.php?project=Slicer4") but somehow they submit to SlicerPreview project, too.

The setting of drop location when extensions are build is set in Extensions/CMake/SlicerExtensionsDashboardDriverScript.cmake, currently the project is hardcoded to Slicer4 for stable extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants