Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment editor paint brush cannot be resized using shift+mousewheel on Mac #4661

Closed
slicerbot opened this issue Mar 13, 2020 · 2 comments · Fixed by #5101
Closed

Segment editor paint brush cannot be resized using shift+mousewheel on Mac #4661

slicerbot opened this issue Mar 13, 2020 · 2 comments · Fixed by #5101
Assignees
@Sunderlandkyl
Milestone
Slicer 4.13

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@Sunderlandkyl
Copy link
Member

Sunderlandkyl commented Aug 4, 2020 •
edited

I've discovered what the issue is.

VTK only checks the Y axis on mouse wheel events, however on MacOS, shift+mousewheel is mapped to the X axis.

To fix this issue I plan to add a MouseWheelLeftEvent and MouseWheelRIghtEvent to VTK, which will behave the same as the existing MouseWheelForwardEvents and MouseWheelBackwardEvents.

@lassoan
Copy link
Contributor

lassoan commented Aug 4, 2020

Nice catch! Thanks for working on this.

Sunderlandkyl added a commit to Sunderlandkyl/Slicer that referenced this issue Aug 14, 2020
@Sunderlandkyl
BUG: Fix paint brush resize using shift+mousewheel on MacOS
e5db4ea 
Vertical mousewheel+shift on MacOS is mapped to the horizontal, rather than vertical axis.
As a result, using shift+mousewheel to resize the paintbrush was not functional on MacOS.

Fixed by allowing both MouseWheelForward/BackwardEvent and MouseWheelLeft/RightEvent for paint brush resize.

Fixes Slicer#4661
@Sunderlandkyl Sunderlandkyl mentioned this issue Aug 14, 2020
Merged
Sunderlandkyl added a commit that referenced this issue Aug 14, 2020
@Sunderlandkyl
BUG: Fix paint brush resize using shift+mousewheel on MacOS
5c04a33 
Vertical mousewheel+shift on MacOS is mapped to the horizontal, rather than vertical axis.
As a result, using shift+mousewheel to resize the paintbrush was not functional on MacOS.

Fixed by allowing both MouseWheelForward/BackwardEvent and MouseWheelLeft/RightEvent for paint brush resize.

Fixes #4661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sunderlandkyl Sunderlandkyl

Labels
None yet
Milestone
Slicer 4.13
Development

Successfully merging a pull request may close this issue.

BUG: Fix paint brush resize using shift+mousewheel on MacOS Sunderlandkyl/Slicer
3 participants
@lassoan @Sunderlandkyl @slicerbot