Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw effect does not take parent transform into account #4685

Closed
slicerbot opened this issue Mar 13, 2020 · 3 comments
Closed

Draw effect does not take parent transform into account #4685

slicerbot opened this issue Mar 13, 2020 · 3 comments
Assignees
Labels
Type: Bug Something isn't working correctly
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@lassoan
Copy link
Contributor

lassoan commented Mar 26, 2020

@Sunderlandkyl Could you please check how difficult would it be to fix this?

@Sunderlandkyl
Copy link
Member

Sunderlandkyl commented Mar 26, 2020

Still looking at a fix, but this issue applies to both the draw and level-tracing effects.

Edit: Also affects islands effect.

Sunderlandkyl added a commit to Sunderlandkyl/Slicer that referenced this issue Mar 27, 2020
The polydata for the draw effect was rasterized in the world coordinate system.
If the segmentation node was under a transform node, the transform would not be taken into account when modifying the segment.

This commit transforms the rasterized image to the same coordinate system as the segmentation before appending it to the modifier labelmap.

re Slicer#4685
Sunderlandkyl added a commit to Sunderlandkyl/Slicer that referenced this issue Mar 27, 2020
The polydata for the draw effect was rasterized in the world coordinate system.
If the segmentation node was under a transform node, the transform would not be taken into account when modifying the segment.

This commit transforms the rasterized image to the same coordinate system as the segmentation before appending it to the modifier labelmap.

re Slicer#4685
lassoan pushed a commit that referenced this issue Mar 27, 2020
The polydata for the draw effect was rasterized in the world coordinate system.
If the segmentation node was under a transform node, the transform would not be taken into account when modifying the segment.

This commit transforms the rasterized image to the same coordinate system as the segmentation before appending it to the modifier labelmap.

re #4685
Sunderlandkyl added a commit to Sunderlandkyl/Slicer that referenced this issue Mar 27, 2020
The position of the mouse in IJK coordinates, as well as the position of the polydata did not previously take into account the parent transform of the segmentation.

re Slicer#4685
Sunderlandkyl added a commit that referenced this issue Mar 27, 2020
The position of the mouse in IJK coordinates, as well as the position of the polydata did not previously take into account the parent transform of the segmentation.

re #4685
lassoan pushed a commit that referenced this issue Mar 27, 2020
The position of the mouse in IJK coordinates, as well as the position of the polydata did not previously take into account the parent transform of the segmentation.

re #4685
@lassoan lassoan added the Type: Bug Something isn't working correctly label Mar 27, 2020
@lassoan
Copy link
Contributor

lassoan commented Mar 27, 2020

Fixed.

@lassoan lassoan closed this as completed Mar 27, 2020
Sunderlandkyl added a commit to Sunderlandkyl/Slicer that referenced this issue Mar 28, 2020
The position of the mouse in IJK coordinates did not previously take into account the parent transform of the segmentation.

re Slicer#4685
Sunderlandkyl added a commit that referenced this issue Mar 28, 2020
The position of the mouse in IJK coordinates did not previously take into account the parent transform of the segmentation.

re #4685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working correctly
Development

No branches or pull requests

3 participants