Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOMReaders test report missing fixedCorners attribute #4686

Open
slicerbot opened this issue Mar 13, 2020 · 2 comments
Open

DICOMReaders test report missing fixedCorners attribute #4686

slicerbot opened this issue Mar 13, 2020 · 2 comments
Assignees
Milestone

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@jamesobutler
Copy link
Contributor

The traceback mentioned in the passing test case doesn’t appear to be happening anymore on the factory builds. I think the traceback was the result of the loading not actually returning a volume node reference due to some failure, but there was improvements to the downloading of files in 80870c3 that helped make sure loading was successful.

@pieper
Copy link
Member

pieper commented Jun 5, 2020

I think @jcfr 's concern was that the testing infrastructure didn't detect that the traceback was a failure mode so the test was incorrectly marked as passing. Not sure if that's been addressed yet.

@lassoan lassoan modified the milestones: Slicer 4.13.0, Backlog Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants