View Issue Details

IDProjectCategoryView StatusLast Update
0004686Slicer4Core: Scripting (Wrapping, Python)public2019-04-03 14:57
ReporterjcfrAssigned Tojcfr 
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
Product VersionSlicer 4.11.0 
Target VersionSlicer 4.11.0Fixed in Version 
Summary0004686: DICOMReaders test report missing `fixedCorners` attribute
Description

While the test pass, it shouldn't report this exception. Testing infrastructure should also be improved to catch this error.

This change is independent of the Python3 updates and occurred with Slicer <= r28055 (see http://slicer.cdash.org/testDetails.php?test=9549115&build=1551601)

$ ctest -R DICOMReader -V
[...]
Irregular volume geometry detected (maximum error of 16.5664 mm is above tolerance threshold of 0.001 mm).  Regularization transform is not added, as the option is disabled.
Traceback (most recent call last):
  File "/Volumes/Dashboards/Preview/Slicer-0/Applications/SlicerApp/Testing/Python/DICOMReaders.py", line 279, in test_MissingSlices
    if not numpy.allclose(scalarVolumePlugin.acquisitionModeling.fixedCorners[-1], lastSliceCorners):
AttributeError: 'AcquisitionModeling' object has no attribute 'fixedCorners'
Missing Slices Test caused exception!
'AcquisitionModeling' object has no attribute 'fixedCorners'
Restoring original database directory
[...]
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-04-03 14:56 jcfr New Issue
2019-04-03 14:56 jcfr Status new => assigned
2019-04-03 14:56 jcfr Assigned To => jcfr
2019-04-03 14:57 jcfr Description Updated View Revisions