Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slicer to build against latest VTK #4696

Closed
3 of 4 tasks
slicerbot opened this issue Mar 13, 2020 · 1 comment · Fixed by #5141
Closed
3 of 4 tasks

Update Slicer to build against latest VTK #4696

slicerbot opened this issue Mar 13, 2020 · 1 comment · Fixed by #5141
Assignees
Labels
Priority: Medium Issues that we plan to fix but there are available workarounds Type: Enhancement Improvement to functionality
Milestone

Comments

@slicerbot
Copy link
Collaborator

slicerbot commented Mar 13, 2020

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.

Current status and remaining work:

@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@sjh26 sjh26 added Priority: Urgent Issues that need immediate attention, such as application crash or data corruption Type: Enhancement Improvement to functionality labels Mar 18, 2020
@lassoan lassoan added Priority: Medium Issues that we plan to fix but there are available workarounds and removed Priority: Urgent Issues that need immediate attention, such as application crash or data corruption labels Mar 19, 2020
@jcfr jcfr self-assigned this Mar 23, 2020
jcfr added a commit to jcfr/Slicer that referenced this issue Apr 1, 2020
jcfr added a commit to jcfr/Slicer that referenced this issue Apr 1, 2020
This commit appends a semi-colon to avoid build error with
VTK >= Kitware/VTK@5ec93e4b6 (clang-format: require semicolons on macros
Forcing semicolons allows clang-format to properly format code using the
macros.)

See Slicer#4696
jcfr added a commit to jcfr/Slicer that referenced this issue Apr 1, 2020
This commit is a follow-up of 0290f72 (COMP: Disable copy
of all VTK based objects)

See Slicer#4696
jcfr added a commit to jcfr/Slicer that referenced this issue Apr 1, 2020
This commit was crafted while working on adding support
for building against VTK 9.0

See Slicer#4696

Co-authored-by: Andras Lasso <lasso@queensu.ca>
jcfr added a commit that referenced this issue Apr 1, 2020
This commit appends a semi-colon to avoid build error with
VTK >= Kitware/VTK@5ec93e4b6 (clang-format: require semicolons on macros
Forcing semicolons allows clang-format to properly format code using the
macros.)

See #4696
jcfr added a commit that referenced this issue Apr 1, 2020
This commit is a follow-up of 0290f72 (COMP: Disable copy
of all VTK based objects)

See #4696
jcfr added a commit that referenced this issue Apr 1, 2020
This commit was crafted while working on adding support
for building against VTK 9.0

See #4696

Co-authored-by: Andras Lasso <lasso@queensu.ca>
@jamesobutler
Copy link
Contributor

@jcfr jcfr linked a pull request Aug 27, 2020 that will close this issue
20 tasks
@jcfr jcfr closed this as completed in #5141 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Issues that we plan to fix but there are available workarounds Type: Enhancement Improvement to functionality
Development

Successfully merging a pull request may close this issue.

5 participants