Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkable button behavior is not intuitive #4717

Closed
slicerbot opened this issue Mar 13, 2020 · 2 comments · Fixed by #4980
Closed

Checkable button behavior is not intuitive #4717

slicerbot opened this issue Mar 13, 2020 · 2 comments · Fixed by #4980
Assignees
@lassoan
Milestone
Slicer 4.13

Comments

@slicerbot
Copy link
Collaborator

This issue was created automatically from an original Mantis Issue. Further discussion may take place here.
@slicerbot slicerbot added this to the Slicer 4.11.0 milestone Mar 13, 2020
@lassoan lassoan self-assigned this Mar 26, 2020
@jamesobutler
Copy link
Contributor

It appears that @Sunderlandkyl issued commontk/CTK@33286e5 and then the corresponding updated in Slicer (9f3c61e) to address the issue based on a user's input. The desired behavior that was implemented was that when the checkbox is checked and the button is in the checked state, then clicking the button puts the button in the unchecked state AND the checkbox is also unchecked. Then clicking the button again is just a momentary push as it is no longer in the checkable state.

This updated behavior can be observed by doing

checkable_button = ctk.ctkCheckablePushButton()
checkable_button .checkBoxControlsButtonToggleState = True
checkable_button.show()

@Sunderlandkyl Is the only remaining thing to do for this issue, is to make the ctkCheckablePushButton in the Volume Rendering module also use this new behavior? It has not yet been updated to use this new logic.

Sunderlandkyl added a commit to Sunderlandkyl/Slicer that referenced this issue Jun 12, 2020
@Sunderlandkyl
ENH: Control volume rendering synchronize scalar button with check box
8b24bd0 
Clicking the check box on the SynchronizeScalarDisplayNodeButton now changes the toggle state of the button. Checked causes the button to be toggled "On" and unchecked causes it to be toggled "Off".

Fixes Slicer#4717
@Sunderlandkyl Sunderlandkyl mentioned this issue Jun 12, 2020
Merged
@Sunderlandkyl
Copy link
Member

Yeah, checkBoxControlsButtonToggleState should fix the behavior. Made a pr #4980.

Sunderlandkyl added a commit that referenced this issue Jun 12, 2020
@Sunderlandkyl
ENH: Control volume rendering synchronize scalar button with check box
4917491 
Clicking the check box on the SynchronizeScalarDisplayNodeButton now changes the toggle state of the button. Checked causes the button to be toggled "On" and unchecked causes it to be toggled "Off".

Fixes #4717
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lassoan lassoan

Labels
None yet
Milestone
Slicer 4.13
Development

Successfully merging a pull request may close this issue.

ENH: Control volume rendering synchronize scalar button with check box Sunderlandkyl/Slicer
4 participants
@lassoan @Sunderlandkyl @slicerbot @jamesobutler